Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PreviousVersion attributes for previous milestones #387

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Remove PreviousVersion attributes for previous milestones #387

merged 1 commit into from
Mar 30, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Mar 29, 2021

Closes #386

@FraserGreenroyd FraserGreenroyd requested a review from adecler March 29, 2021 11:54
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 29, 2021
FraserGreenroyd
FraserGreenroyd approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from a CI/CD perspective. Will let discipline merge when ready.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on ModelLaundry_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BuroHappold_Revit_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BuroHappold_Revit_Toolkit

@adecler
Copy link
Member

adecler commented Mar 30, 2021

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 30, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@adecler adecler merged commit 7207af1 into master Mar 30, 2021
@adecler adecler deleted the BHoMBot-PreviousVersion42 branch March 30, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler Awaiting requested review from adecler

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of PreviousVersion attributes
3 participants
@BHoMBot @adecler @FraserGreenroyd