Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning for LogUsage #383

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

adecler
Copy link
Member

@adecler adecler commented Mar 18, 2021

Closes #382

Two arguments were added to the LogUsage method in this PR. Since this is a public Engine method, it should have provided versioning.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_UI/%23282-LogUsageVersioning?csf=1&web=1&e=SixCyu

LogUsage should not appear in the list of failing methods

Alternatively, you can just pass this to a FromJson component and make sure it deserialise correctly:

{ "_t" : "System.Reflection.MethodBase", "TypeName" : "{ \"_t\" : \"System.Type\", \"Name\" : \"BH.Engine.UI.Compute, UI_Engine, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null\" }", "MethodName" : "LogUsage", "Parameters" : ["{ \"_t\" : \"System.Type\", \"Name\" : \"System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.Guid, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.Object, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\" }", "{ \"_t\" : \"System.Type\", \"Name\" : \"System.Collections.Generic.List`1, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\", \"GenericArguments\" : [{ \"_t\" : \"System.Type\", \"Name\" : \"BH.oM.Reflection.Debugging.Event\" }] }"] }

@adecler adecler added the type:compliance Non-conforming to code guidelines label Mar 18, 2021
@adecler adecler self-assigned this Mar 18, 2021
@adecler adecler added this to the BHoM 4.1 β Release milestone Mar 19, 2021
Copy link

@rolyhudson rolyhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both methods provided.
LGTM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@FraserGreenroyd to confirm, check-versioning task is now queued.

@adecler
Copy link
Member Author

adecler commented Mar 23, 2021

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@adecler sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to run?
For a list of available instructions, please see this wiki page.

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@adecler sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to run?
For a list of available instructions, please see this wiki page.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning report is happy so LGTM

@FraserGreenroyd FraserGreenroyd merged commit 3c4105a into master Mar 23, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#382-VersioningForLogUsage branch March 23, 2021 10:15
@FraserGreenroyd FraserGreenroyd changed the title UI_Engine: Add versioning for LogUsage Add versioning for LogUsage Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI_Engine: LogUsage method doesn't provide versioning for changes made this milestone
3 participants