-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning for LogUsage #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with both methods provided.
LGTM
@BHoMBot check versioning |
@FraserGreenroyd to confirm, |
@BHoMBot check copyright-compliance |
@adecler sorry, I didn't understand. |
1 similar comment
@adecler sorry, I didn't understand. |
@adecler to confirm, |
@BHoMBot check installer |
@FraserGreenroyd to confirm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versioning report is happy so LGTM
Closes #382
Two arguments were added to the LogUsage method in this PR. Since this is a public Engine method, it should have provided versioning.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_UI/%23282-LogUsageVersioning?csf=1&web=1&e=SixCyu
LogUsage
should not appear in the list of failing methodsAlternatively, you can just pass this to a
FromJson
component and make sure it deserialise correctly: