Set m_OriginalMethod to null when selecting a type #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwemay
reviewed
Jun 29, 2020
alelom
approved these changes
Jun 30, 2020
|
Seems to be fine with Dynamo too. |
al-fisher
approved these changes
Jun 30, 2020
|
/azp run BHoM_UI.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
al-fisher
deleted the
BHoM_UI-#284-SetOriginalMethodToNullWhenSelectingType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #284
as stated in issue:
When
SetItemis called for the general case that a method is being picked,m_OriginalMethodis being handled and set to the corresponding method or nulled out if not used in theSetItemon the method called.On the CreateCaller on the other hand, when a type is selected,
m_OriginalMethodis not touched.For Grasshopper and dynamo this is not an issue, as they have a one-to-one relation between a component and one caller. For excel on the other hand this becomes an issue, as Excel_UI only owns one of each caller type, which is being used for all the calls that goes through that particular caller.
This means that if a create method is called, followed by a property assignment method, basically method followed by type,
m_OriginalMethodis still set to the method.This in turn causes issues with the serialisation of the component, as selected item prioritises
m_OriginalMethodoverSelectedItemwhen turned to JSON.Test files
This is all happening on adding methods, hence no test file can be provided. In Excel: Try Creating an object with a create method, then creating an obejct with a property initialiser. Then either look at how the methods have been stored, and/or save and reopen the sheet.
Alsno need to make sure this does not cause any issues elsewhere in the other UIs.
Changelog
Additional comments