Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SearchItems for components #267

Merged
merged 1 commit into from
May 22, 2020
Merged

Update SearchItems for components #267

merged 1 commit into from
May 22, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented May 21, 2020 •
edited
Loading

Issues addressed by this PR

Closes #252

See issue for full discussion. Thre things are done in this PR:

  • Refresh the display text for those to match Al's suggestion
  • Move them to a separate method to better highlight their existence and improve availability separately from the other search items if needed
  • Fix the name of Delete -> Remove and CreateDictionary that was named CreateCustom

I recommend, reviewing this alongside BHoM/Grasshopper_UI#515 as the two PRs are closely related.

@adecler adecler added the type:feature New capability or enhancement label May 21, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 21, 2020
@adecler adecler requested review from alelom, rwemay and al-fisher May 21, 2020 03:13
@adecler adecler self-assigned this May 21, 2020
@adecler adecler mentioned this pull request May 21, 2020
Merged
al-fisher
al-fisher approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adecler
This looks good and sensible to me.
Naming matches as discussed and so logical to me too 😄

@rwemay as originator of this, good to check you are happy with resulting convention

@adecler
Copy link
Member Author

adecler commented May 22, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rwemay
Copy link
Member

rwemay commented May 22, 2020

Yep, thanks LGTM

@adecler adecler merged commit a99ebd0 into master May 22, 2020
@adecler adecler deleted the BHoM_UI-#252-UpdateComponentSearchItem branch May 22, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-fisher al-fisher al-fisher approved these changes

@alelom alelom Awaiting requested review from alelom

@rwemay rwemay Awaiting requested review from rwemay

Assignees

@adecler adecler

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Create friendly names for BHoM_UI core methods
3 participants
@adecler @rwemay @al-fisher