Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite MethodCaller.Write() so it saves its original method #266

Merged
merged 1 commit into from
May 16, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented May 15, 2020

Issues addressed by this PR

Closes #265

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/Ea5xdAvCGIFNjNsL0a7vIp0BVnVz5v5_H1XqPuOV2hIFwA?e=vDwxva

You will need BHoM/BHoM_Engine#1740 and BHoM/BHoM#852 to test with that file

The ItemsInRange component already saved will still fail but any new component created and copy/saved will work fine.

@adecler adecler added the type:bug Error or unexpected behaviour label May 15, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 15, 2020
@adecler adecler self-assigned this May 15, 2020
Copy link

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now,

LGTM

@adecler
Copy link
Member Author

adecler commented May 16, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler adecler merged commit 5a3f63f into master May 16, 2020
@adecler adecler deleted the BHoM_UI-#265-GenericMethodCallerSerialisation branch May 16, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_UI: MethodCallers should serialise their original method
2 participants