Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI_PostBuild: Fix UnauthorizedAccessException on PostBuild CopyUpgrades #259

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented May 8, 2020

Issues addressed by this PR

Closes #251

I decided to go with Al'second option. I mentioned that it would not work for the Dynamo folder but I started to think this is actually a good thing. That folder is purposefully structured to avoid being transferred to the Roaming folder so it makes sense that it also avoid the versioning picking. Something to deal with Dynamo toolkit either way and should not influence what is done here.

@adecler adecler added the type:bug Error or unexpected behaviour label May 8, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 8, 2020
@adecler adecler requested review from al-fisher and IsakNaslundBh May 8, 2020 07:30
@adecler adecler self-assigned this May 8, 2020
@IsakNaslundBh
Copy link
Contributor

@al-fisher do you want to have a first look at this, as I did not experience any problems before.

@adecler
Copy link
Member Author

adecler commented May 8, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adecler
This is working for me now. Thanks

@IsakNaslundBh worth a second review - if you can also confirm.

Note I have raised an unrelated issue here https://github.com/BHoM/Excel_Toolkit/issues/225 - but which others might stumble across too (as I did) if doing a test from fresh and clean rebuilds.

@adecler adecler merged commit a3a3cf6 into master May 9, 2020
@adecler adecler deleted the UI_PostBuild-#251-FixCopyUpgradesUnauthorisedAccess branch May 9, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing System.UnauthorizedAccessException on PostBuild CopyUpgrades
3 participants