Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compliance issue for CSProj files #258

Merged
merged 3 commits into from
May 8, 2020
Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented May 8, 2020

Issues addressed by this PR

Closes #257

Additional comments

I had to keep the references local for the PostBuid.exe to be able to run properly. I have raised a separate issue to compile it to a different folder than Build.

@adecler adecler added the type:compliance Non-conforming to code guidelines label May 8, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 8, 2020
@adecler adecler self-assigned this May 8, 2020
@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_UI.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See compliance report, also, think UI_oM should be referenced to the engine by project reference, and not by dll reference from build folder.

Think those are unrelated to the PostBuild issues you mention arnaud.

@adecler
Copy link
Member Author

adecler commented May 8, 2020

\azp run BHoM_UI.CheckInstaller

@adecler adecler requested a review from IsakNaslundBh May 8, 2020 10:08
@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_UI.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler
Copy link
Member Author

adecler commented May 8, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking fine now

@adecler adecler merged commit 35a43ef into master May 8, 2020
@adecler adecler deleted the BHoM_UI-#257-CsProjCompliance branch May 8, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compliance issue for CSProj files
2 participants