-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle HashSet, FragmentSet,... as input list #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on autoconstructors of objects with HashSet
properties, works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and works fine as long as everything is plugged in, but found some cases that crashes out:
- Adding a fragments input and leaving it unplugged makes the component go red and give a "1. Solution exception:Object reference not set to an instance of an object." error. I know you can just remove the input and that it only happens if a user explicitly has added it, but think it would be good for this to just work.
- Adding two of the same fragment type crashes with the same "1. Solution exception:Object reference not set to an instance of an object." error. This arguably should be crashing, but an error like "Can only add one fragment of a particular type to a BHoMObject" or similar instead of a null reference exception would be better I think:
Apart from that, things seem to be working well. Also love that fragments now work in the explode! 👍
Thanks @IsakNaslundBh ,
Can you do a final review and approve all five PRs if you're happy with it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues I had got solved with the latest commit(s), and have not found any problems when using the UI!
/azp run BHoM_UI.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
NOTE: Depends on
BHoM/BHoM#853
BHoM/BHoM_Adapter#228
BHoM/BHoM_Engine#1743
(at least for testing)
Issues addressed by this PR
Closes #154
IEnumerable
types are can now be properly inputted as lists:Test files
Use any CreateObject component as add inputs for Tags and Fragments.
Changelog
Additional comments
I had to do a second commit to fix a problem created from a previous PR: Added inputs to a
CreateObject
component would not work properly after copy paste or reopening the file.