Fix wire disconnects for edge cases of Versioning #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kThorsager
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
So testing this on some local changes and it does not work for 2.3 scripts which I don't mind that much given that we already have warnings and such.
But I've also found it to work for scripts which were saved at a later date, with a note that it's only the method part of the component which updates in the UI (that is the name of the inputs/output remain, which is fine)
But LGTM
|
Yes, I am relying on names as the only thing that gives a way to find the relation between old parameters and new ones. So I prefer not to change them, especially given that it doesn't break anything to leave them be. |
|
/azp run BHoM_UI.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #214
Test files
@kThorsager , I'll let you use whatever file works for you (the one provided in the issue was not reproducing the bug for me so I created my own fake scenario).