Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make oM properties virtual #239

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Apr 7, 2020

Closes #238

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 7, 2020
@FraserGreenroyd FraserGreenroyd requested a review from adecler April 7, 2020 15:06
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be correct in accordance with the issue being resolved by @BHoMBot.

I will leave it to the Toolkit lead to also review and merge as appropriate.

I would recommend the Toolkit lead to do a usual thorough review in case the virtual keyword has been added inadvertently to the wrong properties.

@adecler
Copy link
Member

adecler commented Apr 8, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler adecler merged commit f1b7a67 into master Apr 8, 2020
@adecler adecler deleted the BHoM_UI-#238-MakePropertiesVirtual branch April 8, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add virtual keyword to oM properties
3 participants