Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: Added continuous UValue Calc to SAM method and Overarching UValue Methode for Collections of Elements #3435

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Dec 2, 2024

Issues addressed by this PR

Closes #3434

Added continuous UValue to SAM Method, and added parent methods to get collective UValues for any collection of FacadeElements.

Test files

Test Script

@enarhi enarhi requested a review from vgreen-BH December 2, 2024 23:14
@enarhi enarhi self-assigned this Dec 2, 2024
@enarhi
Copy link
Member Author

enarhi commented Dec 2, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 2, 2024

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Dec 2, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 2, 2024

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Dec 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against linked script. Everything worked as expected.

@enarhi
Copy link
Member Author

enarhi commented Dec 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 4, 2024

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@enarhi enarhi added the type:feature New capability or enhancement label Dec 4, 2024
@enarhi
Copy link
Member Author

enarhi commented Dec 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 4, 2024

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@enarhi
Copy link
Member Author

enarhi commented Dec 4, 2024

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 4, 2024

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

@michaelhoehn michaelhoehn removed the request for review from FraserGreenroyd December 4, 2024 16:23
@michaelhoehn michaelhoehn merged commit 5a5deb6 into develop Dec 4, 2024
13 checks passed
@michaelhoehn michaelhoehn deleted the Facade_Engine-#3434-GeneralUValueMethods branch December 4, 2024 16:28
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants