Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter_Engine: Make sure no hash fragments are stored in AggregateMaterialComposition #3337

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Apr 23, 2024

Issues addressed by this PR

Closes #3335

Change the way the AggregateMaterialComposition method works to align with the counterparts for the takeoffs.

Previous version led to revision fragments being stuck on the material, causing issues later on. It for example lead to continuous calls to other aggregation method to give different hashes.

Test files

here

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Apr 23, 2024
@IsakNaslundBh IsakNaslundBh requested a review from alelom April 23, 2024 13:43
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 23, 2024
The unit tests that were failing due to the changes where:
Mass:
- Numerical tolerance issue where the mass for some panels where mass was differing on the 14th significant digit
For the rest:
-Fragments no longer present (which is the sole intention of this PR)
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, test script works.

image

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 24, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 273 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 24, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

There are 2 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 24, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 24, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 24, 2024

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24202151496

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24202151496

Copy link

bhombot-ci bot commented Apr 24, 2024

@IsakNaslundBh I have now provided a passing check on reference 24202151496 as requested.

@IsakNaslundBh
Copy link
Contributor Author

Dispensating UTs as non of the failing ones are related to this PR

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 25, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 74 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 7cb0fb1 into develop Apr 25, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Matter_Engine-#3336-DefaultToIgnoreBHoM_GuidForAggregateMethods branch April 25, 2024 08:03
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matter_Engine: AggregateMaterialComposition is leaving hashes on materials
2 participants