-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter_Engine: Make sure no hash fragments are stored in AggregateMaterialComposition #3337
Matter_Engine: Make sure no hash fragments are stored in AggregateMaterialComposition #3337
Conversation
The unit tests that were failing due to the changes where: Mass: - Numerical tolerance issue where the mass for some panels where mass was differing on the 14th significant digit For the rest: -Fragments no longer present (which is the sole intention of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 273 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
The check |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24202151496 |
@IsakNaslundBh I have now provided a passing check on reference |
Dispensating UTs as non of the failing ones are related to this PR |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 74 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #3335
Change the way the AggregateMaterialComposition method works to align with the counterparts for the takeoffs.
Previous version led to revision fragments being stuck on the material, causing issues later on. It for example lead to continuous calls to other aggregation method to give different hashes.
Test files
here
Changelog
Additional comments