-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Add required methods for Cassette and BuiltUpRibbed properties #3311
Structure_Engine: Add required methods for Cassette and BuiltUpRibbed properties #3311
Conversation
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked using the test script and verified with hand calculations.
Can we update the unit-tests (perhaps in a seperate PR)?
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
The check |
The check |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
The check |
The check |
The check |
The check |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@peterjamesnugent I'm sorry, but I am not authorised to take that instruction from you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1604
Issues addressed by this PR
Adds required methods for new Cassette and BuiltUpRibbed properties:
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231604-AddCassetteAndBuiltUpRibProperties?csf=1&web=1&e=0MwLH7
Changelog
Additional comments