Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Add required methods for Cassette and BuiltUpRibbed properties #3311

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1604

Issues addressed by this PR

Adds required methods for new Cassette and BuiltUpRibbed properties:

  • Descriptions
  • VolumePerArea
  • TotalThickness
  • MaterialComposition
  • MassPerArea

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231604-AddCassetteAndBuiltUpRibProperties?csf=1&web=1&e=0MwLH7

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Mar 4, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 4, 2024
@IsakNaslundBh IsakNaslundBh requested a review from rwemay as a code owner March 4, 2024 11:09
@IsakNaslundBh IsakNaslundBh changed the title Structure o m #1601 add cassette and built up rib properties Structure_Engine: Add required methods for Cassette and BuiltUpRibbed properties Mar 4, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked using the test script and verified with hand calculations.

Can we update the unit-tests (perhaps in a seperate PR)?

@peterjamesnugent
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 5, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 5, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 5, 2024

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Mar 5, 2024

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Mar 5, 2024

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 5, 2024

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 5, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 5, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 5, 2024

@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.

@peterjamesnugent
Copy link
Member

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 5, 2024

@peterjamesnugent I'm sorry, but I am not authorised to take that instruction from you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 5, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 5bcc6bb into develop Mar 5, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Structure_oM-#1601-AddCassetteAndBuiltUpRibProperties branch March 5, 2024 23:11
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants