Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings_Engine: Add LoadSettings method for loading a single settings file #3300

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3299

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Feb 27, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Feb 27, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 27, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check installer

Copy link

bhombot-ci bot commented Feb 27, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check core
  • check serialisation
  • check null-handling
  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Feb 27, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful for when we want to load settings for toolkits easily. Approved.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 27, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 3291d50 into develop Feb 27, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Settings_Engine-#3299-LoadSingleFile branch February 27, 2024 11:25
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings_Engine: Ability to load single JSON file settings into memory
2 participants