Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: numerical solution in IsCoplanar replaced with geometrical one #3298

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 26, 2024

Issues addressed by this PR

Closes #2423
Closes #3294

Test files

General test files for the methods changed in this PR uploaded to SharePoint
Test file for #2423 linked in the issue

Changelog

Additional comments

This is the last PR in the current push in Geometry_Engine 🙈

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Feb 26, 2024
@pawelbaran pawelbaran self-assigned this Feb 26, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Feb 26, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 26, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the two scripts provided and the duplicate point script.

My one comment would be to make sure the various Geometry_Engine test scripts this milestone get incorperated into unit tests (in a seperate PR) so they don't get forgotten about.

@pawelbaran
Copy link
Member Author

Thanks @peterjamesnugent for the review. Updating the UTs is on my radar, to be done in sprint 6 based on #3277 👍

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 58ccf39 into develop Mar 1, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3294-GeometricalIsCoplanarNew branch March 1, 2024 12:13
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
IsakNaslundBh added a commit that referenced this pull request Apr 22, 2024
UTs started failing after change of IsPlanar methodology in #3298
For this, the panels have been made planar by projected them to their plane. Panels failing where out of plane by ~2e-6, hence tests should still be valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants