-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: numerical solution in IsCoplanar replaced with geometrical one #3298
Geometry_Engine: numerical solution in IsCoplanar replaced with geometrical one #3298
Conversation
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using the two scripts provided and the duplicate point script.
My one comment would be to make sure the various Geometry_Engine test scripts this milestone get incorperated into unit tests (in a seperate PR) so they don't get forgotten about.
Thanks @peterjamesnugent for the review. Updating the UTs is on my radar, to be done in sprint 6 based on #3277 👍 |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
UTs started failing after change of IsPlanar methodology in #3298 For this, the panels have been made planar by projected them to their plane. Panels failing where out of plane by ~2e-6, hence tests should still be valid.
Issues addressed by this PR
Closes #2423
Closes #3294
Test files
General test files for the methods changed in this PR uploaded to SharePoint
Test file for #2423 linked in the issue
Changelog
Additional comments
This is the last PR in the current push in Geometry_Engine 🙈