-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Singular Value Decomposition algorithm applied to FitPlane method #3290
Conversation
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using develop and then this branch.
Improvement considering the cases provided.
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@BHoMBot check ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
Apologies for commenting under a merged PR, but @peterjamesnugent I am afraid I have not linked the test files that I prepared. Just FYI, there is a test script covering general cases as well as edge ones that broke the original solution. I will aggregate all test content that I prepared in the recent weeks and push in a single attempt to close out #3277 👍 |
Issues addressed by this PR
Closes #3287
Test files
On SharePoint
Changelog
Additional comments