Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Singular Value Decomposition algorithm applied to FitPlane method #3290

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 23, 2024

Issues addressed by this PR

Closes #3287

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Feb 23, 2024
@pawelbaran pawelbaran self-assigned this Feb 23, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 23, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 13 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Feb 25, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using develop and then this branch.

Improvement considering the cases provided.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Feb 26, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 26, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 26, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 26, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 26 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 31cb2b5 into develop Feb 26, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3287-ImproveFitPlane branch February 26, 2024 14:52
@pawelbaran
Copy link
Member Author

Apologies for commenting under a merged PR, but @peterjamesnugent I am afraid I have not linked the test files that I prepared. Just FYI, there is a test script covering general cases as well as edge ones that broke the original solution.

I will aggregate all test content that I prepared in the recent weeks and push in a single attempt to close out #3277 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Rewrite FitPlane method to leverage Singular Value Decomposition
3 participants