Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security_Engine: Camera Field of View bug fix #3266

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3265

  • arc creation bug fixed
  • skip obstacles if camera device is inside (don't return null as before)

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jan 26, 2024
@michal-pekacki michal-pekacki self-assigned this Jan 26, 2024
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 26, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 29, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 29, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense in general, only one small question asked

Security_Engine/Compute/CameraFieldOfView.cs Outdated Show resolved Hide resolved
@michal-pekacki michal-pekacki force-pushed the SecurityICT_Tool-#23-CFOV-Redesign branch from 96b6497 to d34c4af Compare February 1, 2024 16:26
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns code-wise, happy to see this merged if the workflows benefit 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 2, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 2, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Feb 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 2, 2024

@michal-pekacki just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on Revit_Toolkit

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Feb 2, 2024

@michal-pekacki to confirm, the following actions are now queued:

  • check unit-tests

Copy link

bhombot-ci bot commented Feb 2, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21146284981

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21146284981

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd I have now provided a passing check on reference 21146284981 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit ec9ef1f into develop Feb 2, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the SecurityICT_Tool-#23-CFOV-Redesign branch February 2, 2024 11:20
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security_Engine: Camera Field Of View Bug Fix
3 participants