-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security_Engine: Camera Field of View bug fix #3266
Conversation
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense in general, only one small question asked
96b6497
to
d34c4af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns code-wise, happy to see this merged if the workflows benefit 👍
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
|
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
The check |
The check |
@michal-pekacki just to let you know, I have provided a |
@BHoMBot check unit-tests |
@michal-pekacki to confirm, the following actions are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 21146284981 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #3265
Test files
Changelog
Additional comments