Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Align to PointForce renamed to PointLoad #3241

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1582

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 12, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 12, 2024
@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review January 12, 2024 11:24
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check installer

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 15 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on linked PR - updated Enum

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve on account of bot checks passing.

@FraserGreenroyd FraserGreenroyd merged commit ed7a416 into develop Jan 12, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Structure_oM-#643-PointForceToPointLoad branch January 12, 2024 15:26
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants