Structure_Engine: Added an additional Create Method for GeometricalLineLoad

[Arne-Martensen]

NOTE: Depends on

BHoM/BHoM#1565

Issues addressed by this PR

The class GeometricalLineLoad has been modified by adding an attribute, as discussed in BHoM/BHoM#1564. this PR should introduce a new 'Create' method featuring a more intuitive naming and data structure for the input parameters.

Closes #3212

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Engine/Structure_Engine/%233412-ChangesToGeometricalLineLoad/%233412ChangestoGeometricalLineLoad.gh?csf=1&web=1&e=GBLHkr

Changelog

Additional comments

[peterjamesnugent]

Changes needed - as on BHoM/BHoM#1565 (review) can you please make sure the scripts are saved in the right place and combined concisely.

I am getting the following error when pushing to Robot (only when Panels are assigned (which I think is ok because Robot does not actually use the Panels and I don't want to change the fundamental checks that the adapter is making to allow the pushing of GeometricalLineLoads with Panels assigned (that won't be used anyway).

1. The IAreaElements assigned to the GeometricalLineLoad named GeometricalLineLoad - Partial Intersect being pushed does not contain any id-information and can not be identified by the software.
   Please make sure all IAreaElements assigned to the GeometricalLineLoad have been pulled from the package to ensure they contain the necessary information.

[peterjamesnugent]

I have also found it is implemented in the SAP2000_Toolkit:
https://github.com/BHoM/SAP2000_Toolkit/blob/0ad777707dcfbacf906c277f908aa1dd6fcb4cc5/SAP2000_Adapter/CRUD/Create/Loads.cs#L430-L459

But it looks like it will be unaffected.

[Ahmed-buro]

I have tested using the test script using SAP2000 and the functionality is unaffected.

[peterjamesnugent]

Happy to approved based on previous review and recent commits. Tested with Robot_Toolkit to ensure the functionality is changed, similarly @Ahmed-buro has tested with SAP2000.

Changes addressed

[peterjamesnugent]

@BHoMBot check required
@BHoMBot check copyright-compliance

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer
• check copyright-compliance

There are 11 requests in the queue ahead of you.

[bhombot-ci]

@Arne-Martensen just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

[bhombot-ci]

@Arne-Martensen just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

[peterjamesnugent]

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check unit-tests
• check dataset-compliance

There are 4 requests in the queue ahead of you.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral check on: unit-tests

[bhombot-ci]

@Arne-Martensen just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

[bhombot-ci]

@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.