Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Engine: Fix method name spelling #3166

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 1, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #3164

Test files

Changelog

Additional comments

@albinber albinber added the type:compliance Non-conforming to code guidelines label Sep 1, 2023
@albinber albinber requested a review from pawelbaran as a code owner September 1, 2023 10:28
@albinber albinber self-assigned this Sep 1, 2023
@albinber
Copy link
Contributor Author

albinber commented Sep 1, 2023

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16413622442

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16413622442

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@FraserGreenroyd I have now provided a passing check on reference 16413622442 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling is updated, great work @albinber 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 218f60a into develop Sep 1, 2023
@FraserGreenroyd FraserGreenroyd deleted the geometry_engine-#3164-spelling branch September 1, 2023 12:03
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: SignedAngle method name incorrect
2 participants