Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: UX improvement on panel creation #3143

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3096
Fixes #3142

#3142 fallback method fo IInternalEdges
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@EKAdebo EKAdebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair programmed together with @FraserGreenroyd and code works as expected following investigations noted in #3096

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer -quick

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 28 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning -quick

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, code-compliance, unit-tests, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

Versioning failures are not related to this PR. Check dispensated for time being.

@FraserGreenroyd FraserGreenroyd merged commit fd47862 into develop Aug 14, 2023
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3096-ImproveUXOnPanels branch August 14, 2023 16:49
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
2 participants