Serialiser_Engine: Fix serialiser crash on failed

[adecler]

Issues addressed by this PR

Closes #3066

As detailed in the issue, the BHoM UI was crashing on the deserialisation of a specific dataset. It appears that the 'failed' boolean that is passes up from properties to parents was used to force a different deserialisation behaviour inside the SetProperties method.

• The issue is that that boolean is never reset between properties. This means one incorrect property would trigger a failing behaviour on all the following ones.
• Deserialisation is also capable of restoring partial objects by saving the remaining properties inside CustomData. Those objects were still marked as 'failed' though causnig the whole chain of parents to come back as Custom objects.

As the only place where the 'failed' boolean is used for a conditional check is inside the SetProperty method (where it is incorrectly used), I would recommend to get rid of that boolean altogether. We agreed with @FraserGreenroyd to do this in two phases:

• Remove the use of the 'failed' boolean inside the SetProperty method (this PR)
• Remove the 'failed' boolean as an argument of all methods (all are private). Issue raised here: Serialiser_Engine: remove the 'failed' bool parameter in the deserialiser methods #3087

Test files

• Make sure the versioning check is passing
• Test on older versioning datasets (at least a year coverage)
• Test on datasets found in the BHoM folder

[adecler]

@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check versioning

There are 14 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check serialisation

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check serialisation

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check unit-tests
@BHoMBot check installer
@BHoMBot check null-handling

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check unit-tests
• check installer
• check null-handling

[FraserGreenroyd]

I have reviewed the code and it's only deleted lines which is always nice to tidy up 😄

I have then performed the following actions on this branch:

• Deserialised Test Sets for Versioning from version 3.3 to 6.1 for objects and methods
  • Some failures are noted during this deserialisation, however, they are either known issues as a result of the new serialisation framework, or not related to this particular work
  • Despite failures, every single test set JSON file deserialised without crashing Rhino/Grasshopper
  • Objects were returned where possible
• Deserialised every dataset housed within BHoM_Datasets
• All datasets deserialised without crashing Rhino/Grasshopper
• Some errors in deserialisation as a result of failing to convert types for objects I do not currently have compiled on my machine, with all other datasets deserialising correctly

In addition, the dataset issue described in the #3066 has also stopped crashing Rhino entirely and deserialises to a dataset but with errors reported as expected.

Thus, I am happy to merge this for wider testing during our 6.2 beta close out sprint this sprint, but this improves the behaviour discussed 😄

[bhombot-ci]

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14265547610

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14265547610

[bhombot-ci]

@FraserGreenroyd I have now provided a passing check on reference 14265547610 as requested.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge