Physical_Engine: Make physical surfaces return material and volume of all content

[IsakNaslundBh]

Issues addressed by this PR

Closes #2895

Updates so that Physical ISurface objects account for inner opening type objects, such as doors and walls, for computation of SolidVolume as well as MaterialComposition.

• Add method for VolumetricMaterialTakeoff
• Make MaterialComposition method rely on new method
• Make SolidVolume rely on the new method

Important that this is changing behaviour, and would impact workflows like LCA, but should be to the better. Important that people using the tools are aware of this. @enarhi when review/merged would you be able to help spread this?

Also, smaller change, is I removed all errors/warnings regarding Void type openings, as imo, it is safe to simply return 0 volume/empty material composition for this type of object, given it by definition is meant to model nothingness.

Test files

Testfile from issue:

Test File

Also good ofc if this can be tested through a few cases.

Changelog

Additional comments

[IsakNaslundBh]

@enarhi if you want this to make the Beta, we need it reviewed kind of ASAP.

[enarhi]

LGTM, tested test file along with a few other use cases and results are consistent and as expected per compliance with other similar calc methods.

[enarhi]

@BHoMBot check compliance

[IsakNaslundBh]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 69 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 4 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check required
@BHoMBot check unit-tests

[IsakNaslundBh]

@enarhi had some silly description mistakes I had to fix. Do you mind re-approving?

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer
• check unit-tests

There are 4 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

Please be advised that the check with reference 11883804830 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 70 additional annotations waiting, made up of 70 errors and 0 warnings.

[enarhi]

LGTM, functionality all there as expected as per previous review.

[FraserGreenroyd]

@BHoMBot check null-handling
@BHoMBot check serialisation

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check null-handling
• check serialisation

There are 5 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check unit-tests

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 40 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check null-handling
• check serialisation
• check versioning

There are 2 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check installer

[IsakNaslundBh]

@BHoMBot check installer

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check installer

There are 7 requests in the queue ahead of you.

[FraserGreenroyd]

Last commit is minor and not sufficiently changes @enarhi review following bot reports to reapproving for merge.

[IsakNaslundBh]

@BHoMBot check ready-to-merge

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check ready-to-merge

There are 4 requests in the queue ahead of you.