Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Engine: Remove failing unit test on random object generation #2993

Merged
merged 1 commit into from
Jan 13, 2023
Merged

BHoM_Engine: Remove failing unit test on random object generation #2993

merged 1 commit into from
Jan 13, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2992

Additional comments

As discussed with @IsakNaslundBh offline - removing failing unit test pending further investigation/set up/work.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 13, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 13, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

IsakNaslundBh
IsakNaslundBh approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this being removed as currently failing.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 8c4aa50 into develop Jan 13, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2992-RemoveUnitTest branch January 13, 2023 10:46
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurred on a unit test
2 participants
@FraserGreenroyd @IsakNaslundBh