Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech_Engine: Remove legacy prototype code #2985

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Speech_Engine: Remove legacy prototype code #2985

merged 1 commit into from
Jan 9, 2023

Conversation

al-fisher
Copy link
Member

Issues addressed by this PR

Closes #94

@al-fisher al-fisher added the type:compliance Non-conforming to code guidelines label Jan 9, 2023
@al-fisher al-fisher requested a review from rwemay as a code owner January 9, 2023 11:35
@al-fisher al-fisher self-assigned this Jan 9, 2023
@al-fisher al-fisher requested a review from adecler as a code owner January 9, 2023 11:35
@al-fisher
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@al-fisher to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

FraserGreenroyd
FraserGreenroyd approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are deleted and thus are cleaned, what's not to love? 😄 ❤️

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit f2b5cb8 into develop Jan 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the SpeechEngine-#94-RemoveNonCompliantPrototypeCode branch January 9, 2023 12:00
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@al-fisher al-fisher

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speech_Engine : Refactor to BHoM 2.0
2 participants
@al-fisher @FraserGreenroyd