-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Correctly pass tolerance for LineIntersection methods #2903
Geometry_Engine: Correctly pass tolerance for LineIntersection methods #2903
Conversation
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check code-compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy about the changes (clear improvement), but as discussed with @IsakNaslundBh offline, the whole concept of line infinity looks pretty overcooked now, possibly we could get rid of useInfiniteLine
argument and simply drive the queries by Line.Infinite
? Of course not for this PR, more of a general thought.
@IsakNaslundBh to confirm, the following actions are now queued:
There are 41 requests in the queue ahead of you. |
@IsakNaslundBh could we consider adding some Unit Tests for this in the future (happy for it to be a new issue if desired)? |
Yes, we can. Will handle spearately. Issue raised here #2904 |
Issues addressed by this PR
Closes #2902
Fixes tolerances being correctly passed to method doing actual work in line intersections.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EuTzNW600kpFglxk53P9rlEBW6FsOhhmEEgKMHqCnCCLeQ?e=hhoZ9M
Changelog
Additional comments
Changed the name of the file from LineIntersections to LineIntersection (removing the plural s) as the code compliance accepts a trailing s on the method relative to the file name, but does not accept it the other way around.