-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: EventRecorded event added together with the correspondent EventArgs #2894
Conversation
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the structure of the code.
There is very little else to review as the functionality is very straightforward.
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #2893
Test files
Pretty simple mechanism on the engine side - to be tested thoroughly by the consumers.
Changelog
Additional comments
See the details in #2893. Extending the diagrams from there with this PR and the concept of
CallContext
as in this post, we land at the flow as below. This has been tested and works as expected.On another note: not sure if
BH.Engine.Base.Compute
is the right place for an event, but it has not been dismissed by neither @IsakNaslundBh nor @alelom - hopefully the others will not mind too.