Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: EventRecorded event added together with the correspondent EventArgs #2894

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Aug 19, 2022

Issues addressed by this PR

Closes #2893

Test files

Pretty simple mechanism on the engine side - to be tested thoroughly by the consumers.

Changelog

Additional comments

See the details in #2893. Extending the diagrams from there with this PR and the concept of CallContext as in this post, we land at the flow as below. This has been tested and works as expected.

image

On another note: not sure if BH.Engine.Base.Compute is the right place for an event, but it has not been dismissed by neither @IsakNaslundBh nor @alelom - hopefully the others will not mind too.

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Aug 19, 2022
@pawelbaran pawelbaran self-assigned this Aug 19, 2022
@pawelbaran pawelbaran changed the title SetCustomEventAction added to extend the existing logging mechanism EventRecorded event added to extend the existing logging mechanism Aug 22, 2022
@pawelbaran pawelbaran changed the title EventRecorded event added to extend the existing logging mechanism EventRecorded event added together with the correspondent EventArgs Aug 22, 2022
@pawelbaran pawelbaran requested a review from adecler August 30, 2022 22:16
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the structure of the code.
There is very little else to review as the functionality is very straightforward.

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 31, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd FraserGreenroyd changed the title EventRecorded event added together with the correspondent EventArgs BHoM_Engine: EventRecorded event added together with the correspondent EventArgs Aug 31, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 31, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests
  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 31 requests in the queue ahead of you.

@adecler adecler merged commit 40d57f7 into main Aug 31, 2022
@adecler adecler deleted the BHoM_Engine-#2893-ExtendEventLoggingMechanism branch August 31, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: Extend the event logging mechanism to allow custom actions
2 participants