Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.ci: Remove failing unit tests pending upgrade #2891

Merged
merged 1 commit into from
Aug 15, 2022
Merged

.ci: Remove failing unit tests pending upgrade #2891

merged 1 commit into from
Aug 15, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Removes 2 failing unit tests that need upgrading but can be done at a separate point by people best placed to do so.

@FraserGreenroyd FraserGreenroyd added the type:test-script Creation of unit test required label Aug 15, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 15, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 16 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

jamesramsden-bh
jamesramsden-bh approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the basis that appropriate code owners are contacted to replace with working tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 33fe178 into main Aug 15, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-RemoveFailingUnitTests branch August 15, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

@rboulton-BH rboulton-BH Awaiting requested review from rboulton-BH

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@alexissantella alexissantella Awaiting requested review from alexissantella

@travispotterBH travispotterBH Awaiting requested review from travispotterBH

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:test-script Creation of unit test required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FraserGreenroyd @jamesramsden-bh