-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Improvements to Facade SolidVolume and MaterialComposition Methods #2853
Facade_Engine: Improvements to Facade SolidVolume and MaterialComposition Methods #2853
Conversation
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot check required |
@enarhi to confirm, the following checks are now queued:
There are 63 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
There are 9 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #2848
Errors and warnings have been improved, and the methods have been tweaked to improve quality of method outputs for various cases.
Test files
#2848 GH and Rhino test files
To test, flip through the different dropdown options for FrameEdge, Opening, and Panel and constructions and confirm that the results / errors that result are as expected, and help inform the user what they need to provide to get the method to work accordingly.