Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: Improvements to Facade SolidVolume and MaterialComposition Methods #2853

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Jun 9, 2022

Issues addressed by this PR

Closes #2848

Errors and warnings have been improved, and the methods have been tweaked to improve quality of method outputs for various cases.

Test files

#2848 GH and Rhino test files

To test, flip through the different dropdown options for FrameEdge, Opening, and Panel and constructions and confirm that the results / errors that result are as expected, and help inform the user what they need to provide to get the method to work accordingly.

@enarhi enarhi requested a review from vgreen-BH June 9, 2022 02:06
@enarhi enarhi requested a review from al-fisher as a code owner June 9, 2022 02:06
@enarhi enarhi self-assigned this Jun 9, 2022
@enarhi enarhi requested review from rwemay and adecler as code owners June 9, 2022 02:06
@enarhi
Copy link
Member Author

enarhi commented Jun 9, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 6 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Jun 9, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 63 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@vgreen-BH vgreen-BH closed this Jun 9, 2022
@vgreen-BH vgreen-BH reopened this Jun 9, 2022
Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@enarhi
Copy link
Member Author

enarhi commented Jun 9, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

There are 9 requests in the queue ahead of you.

@enarhi enarhi added the type:feature New capability or enhancement label Jun 9, 2022
@enarhi
Copy link
Member Author

enarhi commented Jun 9, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit b4edb99 into main Jun 10, 2022
@IsakNaslundBh IsakNaslundBh deleted the Facade_Engine-#2848-MaterialCompositionTweaks branch June 10, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Update MaterialComposition method to return only composition of Non-opening portion of panel
3 participants