Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data_Engine: handle empty tags #2827

Merged
merged 1 commit into from
May 19, 2022

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented May 16, 2022

NOTE: Depends on

Issues addressed by this PR

Closes #2825

Test files

on Sharepoint

Changelog

Additional comments

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 16, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 355 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 17, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance

There are 344 requests in the queue ahead of you.

@JosefTaylor JosefTaylor self-assigned this May 17, 2022
@JosefTaylor JosefTaylor added the type:bug Error or unexpected behaviour label May 17, 2022
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Code looks good, and test scripts works fine.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 619 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit a8d0729 into main May 19, 2022
@IsakNaslundBh IsakNaslundBh deleted the Data_Engine-#2825-handle-empty-tags branch May 19, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data_Engine: AsCustomObject() crashes if the table has a Tags column but the row is empty.
2 participants