Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data_Engine: Set Name and Tag in AsCustomObject() #2821

Merged
merged 3 commits into from
May 12, 2022
Merged

Data_Engine: Set Name and Tag in AsCustomObject() #2821

merged 3 commits into from
May 12, 2022

Conversation

JosefTaylor
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #2820

Test files

Changelog

Additional comments

@JosefTaylor JosefTaylor requested a review from IsakNaslundBh May 11, 2022 21:34
@JosefTaylor JosefTaylor self-assigned this May 11, 2022
@JosefTaylor JosefTaylor added the type:bug Error or unexpected behaviour label May 11, 2022
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 11, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 348 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1210 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1218 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1226 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1234 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1242 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1250 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1258 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1266 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1274 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1282 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1290 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1298 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1306 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1314 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1322 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1330 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1338 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1346 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1354 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1362 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1370 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1378 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1386 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1394 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1402 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1410 requests in the queue ahead of you.

IsakNaslundBh
IsakNaslundBh requested changes May 12, 2022
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Think this just need a slight adjustment as code currently adds the name to both the Name proeprty and to the Name key in the dictionary (without the else if on the tags, the else only is in relation to the Tags).

With that change I think this is good to go!

Data_Engine/Query/ValuesAt.cs Outdated Show resolved Hide resolved
@IsakNaslundBh
fix if/elseif
ffe8072 
Co-authored-by: Isak Näslund <[email protected]>
@JosefTaylor JosefTaylor requested a review from IsakNaslundBh May 12, 2022 13:05
IsakNaslundBh
IsakNaslundBh previously approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me. Tested and approved!

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 347 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 344 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor JosefTaylor requested a review from IsakNaslundBh May 12, 2022 14:06
IsakNaslundBh
IsakNaslundBh approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great. Approved

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 344 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 173ab82 into main May 12, 2022
@IsakNaslundBh IsakNaslundBh deleted the Data_Engine-#2820-fix-name-and-tags-in-Tables-with-CustomObjects branch May 12, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@epignatelli epignatelli Awaiting requested review from epignatelli

Assignees

@JosefTaylor JosefTaylor

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsCustomObject() obliterates Name and Tags
2 participants
@JosefTaylor @IsakNaslundBh