Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Exclusion added to the null checks #2760

Merged

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 28, 2022
@pawelbaran pawelbaran self-assigned this Feb 28, 2022
@pawelbaran pawelbaran requested a review from adecler as a code owner February 28, 2022 18:22
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 20 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Exclusion added to the null checks CI: Exclusion added to the null checks Feb 28, 2022
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines and removed type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Feb 28, 2022
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in line with the work done by @pawelbaran and this is good to include.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance

There are 32 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5364238982

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5364239366

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5364238982

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@FraserGreenroyd I have now provided a passing check on reference 5364238982 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5364239366

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@FraserGreenroyd I have now provided a passing check on reference 5364239366 as requested.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 6 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5365248688

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 4 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 9c2afc5 into main Feb 28, 2022
@pawelbaran pawelbaran deleted the BuroHappold_Revit_Toolkit-#359-RebasedPushToJsonAndDiffing branch February 28, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants