-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: SAM and CAM methods fixed and improved #2731
Facade_Engine: SAM and CAM methods fixed and improved #2731
Conversation
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
|
@enarhi to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
The check |
@BHoMBot check versioning |
@enarhi to confirm, the following checks are now queued:
There are 21 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@enarhi to confirm, the following checks are now queued:
There are 23 requests in the queue ahead of you. |
7f2edd9
to
cf00389
Compare
cf00389
to
a856443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
There are 19 requests in the queue ahead of you. |
@enarhi to confirm, the following checks are now queued:
|
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
There are 17 requests in the queue ahead of you. |
@BHoMBot check required |
@enarhi to confirm, the following checks are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #2662
Fixed reliance on Psi/U Value fragments assigned to Construction properties rather than the element itself, and added multiple opening area weighted functionality.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Facade_Engine/%232662-SAMandCAMMethodUpdates?csf=1&web=1&e=HgP13D