Facade_Engine: Updated SAM and CAM methods and added AW for multiple openings #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enarhi to confirm, the following checks are now queued:
|
enarhi
force-pushed
the
Facade_Engine-#2662-SAMandCAMUpdates
branch
from
5c8fa87 to
bcaaecd
Compare
|
@BHoMBot check compliance |
|
@enarhi to confirm, the following checks are now queued:
There are 9 requests in the queue ahead of you. |
|
@BHoMBot check copyright-compliance |
|
Closed to be replaced by future pr. |
enarhi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #2662
Fixed reliance on Psi/U Value fragments assigned to Construction properties rather than the element itself, and added multiple opening area weighted functionality.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Facade_Engine/%232662-SAMandCAMMethodUpdates?csf=1&web=1&e=HgP13D