-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection_Engine: Add method to detect if an item is part of the curated BHoM #2590
Reflection_Engine: Add method to detect if an item is part of the curated BHoM #2590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor description update that I'm going to commit as part of this review but I have to request changes to achieve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this with a couple of components with and without the included DLLs file.
I'm happy the functionality here is meeting the needs.
However, I am currently holding off approving, simply because if merged (along with the Grasshopper PR), and the installer is not updated to dispatch an included DLLs file to users, all components of the BHoM in the next alpha after merge will be marked as prototype.
I'm happy to approve once the installer is updated (or sooner if there is argument to merge sooner), as the functionality works well.
@adecler I updated one description, worth double checking you're happy with it as well before merge 😄
Thanks @FraserGreenroyd , Having all components tagged as prototypes if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have reviewed again with the changes made for the lack of file option and the colour changes by @IsakNaslundBh and am still happy with functionality. With the PR on the installer also ready to go, I am now approving these in line ready to be merged for tomorrows alpha 😄
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 3299909402 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
Issues addressed by this PR
Contributes to BHoM/Grasshopper_UI#631
Additional comments
@FraserGreenroyd , I have placed your file containing the list of dlls here:
C:\ProgramData\BHoM\Settings\IncludedDlls.txt