Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffing_Engine: DiffWithFragmentId to pass the DiffConfig correctly #2571

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Diffing_Engine: DiffWithFragmentId to pass the DiffConfig correctly #2571

merged 1 commit into from
Jul 30, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Jul 28, 2021

Issues addressed by this PR

Closes #2570

Test files

Changelog

Additional comments

@alelom alelom requested a review from kayleighhoude July 28, 2021 17:13
@alelom alelom requested review from adecler and al-fisher as code owners July 28, 2021 17:13
@alelom alelom self-assigned this Jul 28, 2021
@alelom alelom added the type:bug Error or unexpected behaviour label Jul 28, 2021
kayleighhoude
kayleighhoude approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@kayleighhoude kayleighhoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds ok, seems to be working on my end (I don't see the difference in the results, not sure if that was supposed to be an outcome)

@alelom
Copy link
Member Author

alelom commented Jul 29, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 113 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

There are 20 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit b468807 into master Jul 30, 2021
@FraserGreenroyd FraserGreenroyd deleted the Diffing_Engine-diffConfigPassing branch July 30, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayleighhoude kayleighhoude kayleighhoude approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@alelom alelom

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diffing_Engine: DiffWithFragmentId does not pass the DiffConfig correctly
3 participants
@alelom @FraserGreenroyd @kayleighhoude