Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facade_Engine: Improved Adjacency Methods and Added CurtainWall Methods #2569

Merged
merged 16 commits into from
Aug 4, 2021
Merged

Facade_Engine: Improved Adjacency Methods and Added CurtainWall Methods #2569

merged 16 commits into from
Aug 4, 2021

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Jul 28, 2021

Issues addressed by this PR

Closes #2493
Closes #2568

Added new methods for CurtainWalls and improved functionality of Adjacency methods.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Facade_Engine/%232493-AdjacencyAndCWMethods?csf=1&web=1&e=FP2hDK

@enarhi enarhi added the type:feature New capability or enhancement label Jul 28, 2021
@enarhi enarhi requested a review from vgreen-BH July 28, 2021 01:13
@enarhi enarhi self-assigned this Jul 28, 2021
@enarhi
Copy link
Member Author

enarhi commented Jul 28, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

vgreen-BH
vgreen-BH previously approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed w/ script. LGTM

@enarhi
Copy link
Member Author

enarhi commented Jul 28, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 23 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning
  • ready-to-merge

There are 17 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

FraserGreenroyd
FraserGreenroyd requested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the null-handling that is made worse in this PR @enarhi

@enarhi
Copy link
Member Author

enarhi commented Jul 29, 2021 •
edited
Loading

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@enarhi to confirm, the following checks are now queued:

  • null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 29, 2021

@enarhi to confirm, the following checks are now queued:

  • null-handling

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Aug 3, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@enarhi enarhi requested a review from vgreen-BH August 3, 2021 15:17
@enarhi
Copy link
Member Author

enarhi commented Aug 3, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Aug 3, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

vgreen-BH
vgreen-BH approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BHoM BHoM deleted a comment from vgreen-BH Aug 3, 2021
@enarhi
Copy link
Member Author

enarhi commented Aug 3, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Aug 3, 2021

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

There are 2 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard work pays off @enarhi ! LGTM 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit f866009 into master Aug 4, 2021
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#2493-ImprovedAdjacencyAndCreateMethods branch August 4, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@vgreen-BH vgreen-BH vgreen-BH approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@enarhi enarhi

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
3 participants
@enarhi @FraserGreenroyd @vgreen-BH