Spatial_Engine: Add query dominant vector #2539
Conversation
| return dominantVector; | ||
|
|
||
| //filter grouped vectors to find only curves that are X = 0 or 1 (horizontal or vertical lines) | ||
| var orthogonalVectors = groupByNormal.Where(x => x.First().Normalise().X == 0 || x.First().Normalise().X == 1).ToList(); |
There was a problem hiding this comment.
You should use some tolerance here, otherwise you can end up with 1 != 1 due to numerical noise.
Co-authored-by: Pawel Baran <[email protected]>
Co-authored-by: Pawel Baran <[email protected]>
|
@BHoMBot check required |
|
@tiagogrossi to confirm, the following checks are now queued:
There are 51 requests in the queue ahead of you. |
|
@BHoMBot check required |
|
@pawelbaran to confirm, the following checks are now queued:
There are 112 requests in the queue ahead of you. |
|
@BHoMBot check required |
|
@pawelbaran to confirm, the following checks are now queued:
|
|
Looks like there is a few compliance issues to resolve @tiagogrossi |
|
@BHoMBot check required |
|
@tiagogrossi to confirm, the following checks are now queued:
There are 71 requests in the queue ahead of you. |
|
@BHoMBot check null-handling |
|
@tiagogrossi to confirm, the following checks are now queued:
|
|
@BHoMBot check required |
|
@tiagogrossi to confirm, the following checks are now queued:
|
|
@BHoMBot check copyright-compliance |
|
@tiagogrossi to confirm, the following checks are now queued:
There are 11 requests in the queue ahead of you. |
|
@BHoMBot check dataset-compliance |
|
@tiagogrossi to confirm, the following checks are now queued:
There are 13 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@tiagogrossi to confirm, the following checks are now queued:
There are 15 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@pawelbaran to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #2537
This new method queries
IElement1DandIElement2Dfor their dominant vector (orientation). The logic is very simple, it groups all similar vectors and sort them by summed lengths. The longest length is the dominant vector and hence it's selected. The method also allows for orthogonal vector priority, where if true it tries to return orthogonal vectors, and a angle discrepancy tolerance when grouping vectors.Test files
Test file is here. I have not included a GH proof because quite honestly I don't even know how to do it with standard nodes.
Changelog
Adds
BH.Engine.Spatial.Query.DominantVector