Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialiser_Engine: colour serialisation bug fixed #2502

Merged
merged 1 commit into from
May 13, 2021

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #2501

Test files

On SharePoint.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label May 12, 2021
@pawelbaran pawelbaran requested a review from adecler May 12, 2021 11:18
@pawelbaran pawelbaran self-assigned this May 12, 2021
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2021

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 15 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@FraserGreenroyd I would not mind ignoring the compliance taken that it is a minor bugfix that does not interfere with the method signatures at all.

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2021

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 2565738200

@adecler
Copy link
Member

adecler commented May 13, 2021

@FraserGreenroyd I would not mind ignoring the compliance taken that it is a minor bugfix that does not interfere with the method signatures at all.

This is not a static method so there shouldn't be a test on it related to extension methods.

@adecler
Copy link
Member

adecler commented May 13, 2021

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 13, 2021

@adecler to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine

  • both when Color is a top object and a property
  • both on old version and new

Glad to see that the verification on serialization is also happy

@adecler adecler merged commit bd622bc into master May 13, 2021
@adecler adecler deleted the Serialiser_Engine-#2501-ColourSerialisationBug branch May 13, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser_Engine: System.Drawing.Color fails to deserialise correctly when not being a property of type Color
2 participants