-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: colour serialisation bug fixed #2502
Serialiser_Engine: colour serialisation bug fixed #2502
Conversation
@BHoMBot check required |
@pawelbaran to confirm, the following checks are now queued:
There are 15 requests in the queue ahead of you. |
@FraserGreenroyd I would not mind ignoring the compliance taken that it is a minor bugfix that does not interfere with the method signatures at all. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is code-compliance. If you are providing dispensation on this occasion, please reply with:
|
This is not a static method so there shouldn't be a test on it related to extension methods. |
@adecler to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine
- both when Color is a top object and a property
- both on old version and new
Glad to see that the verification on serialization is also happy
Issues addressed by this PR
Closes #2501
Test files
On SharePoint.
Changelog
Additional comments