Environment_Engine: Skip IInternalEdges when set to null #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check required |
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
FraserGreenroyd
approved these changes
May 4, 2021
There was a problem hiding this comment.
This works well, fixes the bug found by @svaz00 and does not appear to have any side effects 😄
Thanks @JohannaOlin1 for the quick fix!
FraserGreenroyd
deleted the
Environment_Engine-#2496-AccountForInternalBoundaries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #2496
Fixes the bug where PanelsFromPhysical and Panel components are not running for panels with openings without internal edges.
Test files
TestFiles.zip