Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial_Engine: Add FitPlane UnitTest for Spatial elements #2489

Merged

Conversation

LMarkowski
Copy link
Contributor

@LMarkowski LMarkowski commented Apr 20, 2021

Issues addressed by this PR

Refers directly to #2459

Following the discussion on #2445 I'm raising a dummy PR to store all the failing unit tests as long as the issue that causes the errors won't get resolved.
I think this PR could be versatile for all projects across the BHoM_Engine repo. I'm adding the first UT that I encountered in the Spatial_Engine, but occurrences from any other projects can be directed here as well.

Test files

N/A

Additional comments

I'm assigning all of you guys as all of you were at some point involved in creating foundational unit tests. Feel free to unassign or add testers from other projects if you feel so. (Or maybe I should assign you to the issue instead?)

@LMarkowski LMarkowski added type:bug Error or unexpected behaviour type:test-script Creation of unit test required status:WIP PR in progress and still in draft, not ready for formal review labels Apr 20, 2021
@LMarkowski LMarkowski requested a review from adecler as a code owner April 20, 2021 11:11
@LMarkowski
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 20, 2021

@LMarkowski to confirm, check unit-tests task is now queued.

@FraserGreenroyd FraserGreenroyd removed their assignment Apr 20, 2021
@rolyhudson rolyhudson added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label May 14, 2021
@rolyhudson
Copy link
Contributor

Added the do-not-merge tag as this is only for the convenience of keeping toxic unit tests available for when we have time to investigate the reasons.

@rolyhudson rolyhudson marked this pull request as draft May 17, 2021 14:53
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • unit-tests

@IsakNaslundBh IsakNaslundBh force-pushed the BHoM_Engine-#2459-QuarantineForOddlyFailingUnitTests branch from 37f1491 to c2a344f Compare January 4, 2023 11:52
@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 4, 2023 11:52
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@IsakNaslundBh IsakNaslundBh force-pushed the BHoM_Engine-#2459-QuarantineForOddlyFailingUnitTests branch from c2a344f to f271805 Compare January 4, 2023 14:21
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 22 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 1 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review January 5, 2023 07:34
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the item that was failing on the remote (whilst still working on local) to be able to get this merged in. Still not sure why it was failing on the remote, but prefer that this gets merged in rather than simply closed during the PR closure cycle.

Approving on the basis that the UT is now passing

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

There are 45 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

There are 47 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:bug Error or unexpected behaviour status:WIP PR in progress and still in draft, not ready for formal review labels Jan 5, 2023
@IsakNaslundBh IsakNaslundBh changed the title BHoM_Engine: Quarantine for oddly failing unit tests Spatial_Engine: Add FitPlane UnitTest for Spatial elements Jan 5, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check dataset-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

2 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check dataset-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check dataset-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 41 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 42 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit a2b200d into develop Jan 5, 2023
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Engine-#2459-QuarantineForOddlyFailingUnitTests branch January 5, 2023 07:58
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test-script Creation of unit test required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants