-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial_Engine: Add FitPlane UnitTest for Spatial elements #2489
Spatial_Engine: Add FitPlane UnitTest for Spatial elements #2489
Conversation
@BHoMBot check unit-tests |
@LMarkowski to confirm, check |
Added the do-not-merge tag as this is only for the convenience of keeping toxic unit tests available for when we have time to investigate the reasons. |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following checks are now queued:
|
37f1491
to
c2a344f
Compare
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
c2a344f
to
f271805
Compare
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 22 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the item that was failing on the remote (whilst still working on local) to be able to get this merged in. Still not sure why it was failing on the remote, but prefer that this gets merged in rather than simply closed during the PR closure cycle.
Approving on the basis that the UT is now passing
@IsakNaslundBh to confirm, the following actions are now queued:
There are 45 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 47 requests in the queue ahead of you. |
The check |
The check |
The check |
2 similar comments
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 41 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 42 requests in the queue ahead of you. |
Issues addressed by this PR
Refers directly to #2459
Following the discussion on #2445 I'm raising a dummy PR to store all the failing unit tests as long as the issue that causes the errors won't get resolved.
I think this PR could be versatile for all projects across the BHoM_Engine repo. I'm adding the first UT that I encountered in the
Spatial_Engine
, but occurrences from any other projects can be directed here as well.Test files
N/A
Additional comments
I'm assigning all of you guys as all of you were at some point involved in creating foundational unit tests. Feel free to unassign or add testers from other projects if you feel so. (Or maybe I should assign you to the issue instead?)