Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Fix typo in method name + versioning for method as appropriate #2488

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Environment_Engine: Fix typo in method name + versioning for method as appropriate #2488

merged 1 commit into from
Apr 20, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2474

Test files

Changelog

Additional comments

Have versioned as well for the change so this should be good to go if the checks come back green.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Apr 19, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 19, 2021
@FraserGreenroyd FraserGreenroyd requested a review from tg359 as a code owner April 19, 2021 11:43
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Apr 19, 2021 •
edited
Loading

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check dataset-compliance task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 19, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@FraserGreenroyd FraserGreenroyd merged commit e68f595 into master Apr 20, 2021
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2474-Typo branch April 20, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linaeriksson linaeriksson linaeriksson approved these changes

@charliebrookerBH charliebrookerBH Awaiting requested review from charliebrookerBH

@MarthaVoul MarthaVoul Awaiting requested review from MarthaVoul

@akaraiskou akaraiskou Awaiting requested review from akaraiskou

@JohannaOlin1 JohannaOlin1 Awaiting requested review from JohannaOlin1

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Fix typo for SetAdjacentSpaces method
2 participants
@FraserGreenroyd @linaeriksson