Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_Engine: Handle nulls #2476

Merged
merged 1 commit into from
Apr 20, 2021
Merged

BHoM_Engine: Handle nulls #2476

merged 1 commit into from
Apr 20, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2475

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 16, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 16, 2021
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check null-handling task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Apr 16, 2021 •
edited
Loading

@BHoMBot check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Apr 16, 2021 •
edited
Loading

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check dataset-compliance task is now queued.

adecler
adecler approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine for me

@adecler adecler merged commit 4736434 into master Apr 20, 2021
@adecler adecler deleted the BHoM_Engine-#2475-Nulls branch April 20, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base Engine - handle nulls
2 participants
@FraserGreenroyd @adecler