Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffing_Engine: Handle nulls #2469

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Diffing_Engine: Handle nulls #2469

merged 1 commit into from
Apr 22, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2468 - ain't never too late!

Test files

Changelog

Additional comments

Bonus points to whoever gets the reference after the issue number...

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 16, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 16, 2021
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check null-handling task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check dataset-compliance task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 2362894108

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 2362894108

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd I have now provided a passing check on reference 2362894108 as requested.

@alelom
Copy link
Member

alelom commented Apr 19, 2021

@FraserGreenroyd sorry but I think I found a bug: see issue #2489

alelom
alelom approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

@FraserGreenroyd FraserGreenroyd merged commit 436c376 into master Apr 22, 2021
@FraserGreenroyd FraserGreenroyd deleted the Diffing_Engine-#2468-Nulls branch April 22, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@rolyhudson rolyhudson Awaiting requested review from rolyhudson

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diffing_Engine: Fix nulls
2 participants
@FraserGreenroyd @alelom