-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Architecture_Engine: Fix null handling #2463
Conversation
@BHoMBot check required |
@FraserGreenroyd to confirm, the checks for |
Please be advised that the check with reference 2356782861 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the checks for |
Please be advised that the check with reference 2356813991 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings. |
@BHoMBot check null-handling |
@FraserGreenroyd to confirm, check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, check |
@BHoMBot check null-handling |
@FraserGreenroyd to confirm, check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, check |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the checks for |
Please be advised that the check with reference 2360362122 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings. |
@BHoMBot check serialisation |
Co-authored-by: Pawel Baran <[email protected]>
Co-authored-by: Pawel Baran <[email protected]>
Co-authored-by: Pawel Baran <[email protected]>
954263d
to
5bde3de
Compare
@BHoMBot check required |
@FraserGreenroyd to confirm, the checks for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections outside of what I have mentioned in my previous comments in previous PRs of this type.
As mentioned in #2465, I am a bit concerned about the creep that these changes may possibly introduce, but it seems that the only way to check it is to merge and see how many weird behaviours bubble up.
@BHoMBot check required |
@pawelbaran to confirm, the checks for |
Please be advised that the check with reference 2410551417 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 46 additional annotations waiting, made up of 0 errors and 46 warnings. |
Please be advised that the check with reference 2410781195 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 46 additional annotations waiting, made up of 0 errors and 46 warnings. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, check |
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, check |
Issues addressed by this PR
Fixes #2462
Test files
Changelog
Additional comments