Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture_Engine: Fix null handling #2463

Merged
merged 12 commits into from
Apr 22, 2021

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2462

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 15, 2021
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 15, 2021
@FraserGreenroyd FraserGreenroyd requested a review from rwemay as a code owner April 15, 2021 20:57
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

Please be advised that the check with reference 2356782861 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

Please be advised that the check with reference 2356813991 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings.

@FraserGreenroyd FraserGreenroyd changed the title Architecture engine #2462 nulls Architecture_Engine: Fix null handling Apr 15, 2021
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

@FraserGreenroyd to confirm, check null-handling task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 15, 2021

@FraserGreenroyd to confirm, check versioning task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check null-handling task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, check versioning task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, branch-compliance, dataset-compliance, and, if applicable, copyright-compliance are now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 16, 2021

Please be advised that the check with reference 2360362122 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 48 additional annotations waiting, made up of 0 errors and 48 warnings.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check serialisation

@FraserGreenroyd FraserGreenroyd force-pushed the Architecture_Engine-#2462-Nulls branch from 954263d to 5bde3de Compare April 22, 2021 13:24
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections outside of what I have mentioned in my previous comments in previous PRs of this type.

As mentioned in #2465, I am a bit concerned about the creep that these changes may possibly introduce, but it seems that the only way to check it is to merge and see how many weird behaviours bubble up.

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

@pawelbaran to confirm, the checks for code-compliance, documentation-compliance, project-compliance, core, null-handling, serialisation, installer, and versioning are now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

Please be advised that the check with reference 2410551417 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 46 additional annotations waiting, made up of 0 errors and 46 warnings.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

Please be advised that the check with reference 2410781195 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 46 additional annotations waiting, made up of 0 errors and 46 warnings.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

@FraserGreenroyd to confirm, check copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 22, 2021

@FraserGreenroyd to confirm, check dataset-compliance task is now queued.

@FraserGreenroyd FraserGreenroyd merged commit 78552eb into master Apr 22, 2021
@FraserGreenroyd FraserGreenroyd deleted the Architecture_Engine-#2462-Nulls branch April 22, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture_Engine - handle nulls
2 participants