-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base_Engine: Create a useable DateTime for RandomObject #2437
Base_Engine: Create a useable DateTime for RandomObject #2437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find any test scripts but replicated what the PR suggested with an Inspection.Issue
. Date related fields had some sufficiently random
dates which resolves the scope of the issue raised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked using a similar script to the one posted in the issue raised, and dates created are all after 1970 so it looks like it's working.
Thanks @adecler!
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the checks for |
@BHoMBot check core |
@FraserGreenroyd to confirm, check |
@BHoMBot check null-handling |
@FraserGreenroyd to confirm, check |
@BHoMBot check serialisation |
@FraserGreenroyd to confirm, check |
@BHoMBot check installer |
@FraserGreenroyd to confirm, check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, check |
@BHoMBot check serialisation |
@FraserGreenroyd to confirm, check |
@BHoMBot check installer |
@FraserGreenroyd to confirm, check |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, check |
Closes #2408
Added code suggestion made in the issue with a few minor tweaks.
Test files
Create random objects of any type that has a
DateTime
property (I used Issue).