Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base_Engine: Create a useable DateTime for RandomObject #2437

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

adecler
Copy link
Member

@adecler adecler commented Mar 31, 2021

Closes #2408

Added code suggestion made in the issue with a few minor tweaks.

Test files

Create random objects of any type that has a DateTime property (I used Issue).

@adecler adecler added the type:bug Error or unexpected behaviour label Mar 31, 2021
@adecler adecler requested a review from tg359 March 31, 2021 03:59
@adecler adecler self-assigned this Mar 31, 2021
@adecler adecler requested a review from al-fisher as a code owner March 31, 2021 03:59
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any test scripts but replicated what the PR suggested with an Inspection.Issue. Date related fields had some sufficiently random dates which resolves the scope of the issue raised.

Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked using a similar script to the one posted in the issue raised, and dates created are all after 1970 so it looks like it's working.

Thanks @adecler!

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Apr 6, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, the checks for code-compliance, documentation-compliance, project-compliance, branch-compliance, dataset-compliance, and, if applicable, copyright-compliance are now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check core task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check null-handling task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check serialisation task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check versioning task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check serialisation task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 6, 2021

@FraserGreenroyd to confirm, check versioning task is now queued.

@FraserGreenroyd FraserGreenroyd merged commit 96e7f7f into master Apr 6, 2021
@FraserGreenroyd FraserGreenroyd deleted the Base_Engine-#ValidDateTimeForRandomObject branch April 6, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: RandomObject creation creates unusable random DateTime dtypes
3 participants