Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PreviousVersion attributes for previous milestones #2431

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Remove PreviousVersion attributes for previous milestones #2431

merged 1 commit into from
Apr 1, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Mar 29, 2021

Closes #2429

FraserGreenroyd
FraserGreenroyd approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from a CI/CD perspective. Will await further reviews before merging.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 29, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on ModelLaundry_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BuroHappold_Revit_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BuroHappold_Revit_Toolkit

adecler
adecler approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

@FraserGreenroyd to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

@FraserGreenroyd to confirm, check-serialisation task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

@FraserGreenroyd to confirm, check-core task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

@FraserGreenroyd to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is check-ready-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 2248787785

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 2248787785

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 1, 2021

@FraserGreenroyd I have now provided a passing check on reference 2248787785 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 0f631ef into master Apr 1, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoMBot-PreviousVersion42 branch April 1, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler adecler approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@epignatelli epignatelli Awaiting requested review from epignatelli epignatelli is a code owner

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of PreviousVersion attributes
3 participants
@BHoMBot @FraserGreenroyd @adecler