Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data_Engine: Requests method moved to Query class #2385

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Data_Engine: Requests method moved to Query class #2385

merged 1 commit into from
Mar 11, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 11, 2021 •
edited
Loading

Issues addressed by this PR

Closes #2332

Test files

Versioning tested here - please remember about rebuilding Versioning_Toolkit.

Changelog

  • Requests method moved to Query class

Additional comments

@pawelbaran pawelbaran added the type:compliance Non-conforming to code guidelines label Mar 11, 2021
@pawelbaran pawelbaran self-assigned this Mar 11, 2021
@pawelbaran
Copy link
Member Author

/azp run BHoM_Engine.CheckInstaller

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-versioning task is now queued.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-serialisation task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-installer task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2021

@pawelbaran to confirm, check-core task is now queued.

FraserGreenroyd
FraserGreenroyd approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, versioning report looks good.

@FraserGreenroyd FraserGreenroyd merged commit a9d185a into master Mar 11, 2021
@FraserGreenroyd FraserGreenroyd deleted the Data_Engine-#2332-RequestsInWrongClass branch March 11, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@LMarkowski LMarkowski Awaiting requested review from LMarkowski

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@epignatelli epignatelli Awaiting requested review from epignatelli epignatelli is a code owner

Assignees

@pawelbaran pawelbaran

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data_Engine: Requests method is in the wrong class
2 participants
@pawelbaran @FraserGreenroyd