Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Fix copy of panels #2376

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Environment_Engine: Fix copy of panels #2376

merged 2 commits into from
Mar 8, 2021

Conversation

rboulton-BH
Copy link
Contributor

@rboulton-BH rboulton-BH commented Mar 8, 2021 •
edited
Loading

@rboulton-BH rboulton-BH self-assigned this Mar 8, 2021
@rboulton-BH rboulton-BH added the type:bug Error or unexpected behaviour label Mar 8, 2021
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2021

@FraserGreenroyd to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2021

@FraserGreenroyd to confirm, check-unit-tests task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2021

@FraserGreenroyd to confirm, check-dataset-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2021

@FraserGreenroyd to confirm, check-core task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd
FraserGreenroyd approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch @rboulton-BH 😄

@FraserGreenroyd FraserGreenroyd merged commit 40b5d28 into master Mar 8, 2021
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2375-bugfix branch March 8, 2021 21:28
@FraserGreenroyd FraserGreenroyd mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

@JohannaOlin1 JohannaOlin1 Awaiting requested review from JohannaOlin1

@linaeriksson linaeriksson Awaiting requested review from linaeriksson

Assignees

@rboulton-BH rboulton-BH

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Bug in identifying overlaps
2 participants
@rboulton-BH @FraserGreenroyd