Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial_Engine: Rigid transformations for IElements0D, IElements1D and IElements2D added #2372

Merged
merged 8 commits into from
Mar 10, 2021
Merged

Spatial_Engine: Rigid transformations for IElements0D, IElements1D and IElements2D added #2372

merged 8 commits into from
Mar 10, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 8, 2021 •
edited
Loading

Issues addressed by this PR

Closes #2320

Test files

On SharePoint - to large extent it is a copy-paste of the Structural_Engine tests showing that the type-specific methods get called as expected. On top of that there are extra tests of the types that do not have Transform methods, therefore using get/set geometry pattern.

Graphics_Engine tests have been place here.

Changelog

  • rigid transformations for IElements0D, IElements1D and IElements2D added
  • Transform method added for BH.oM.Graphics.Vertex and BH.oM.Graphics.RenderMesh

Additional comments

@al-fisher @IsakNaslundBh looks like we are finally getting there.

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Mar 8, 2021
@pawelbaran pawelbaran requested a review from LMarkowski March 8, 2021 11:42
@pawelbaran pawelbaran self-assigned this Mar 8, 2021
@LMarkowski
Copy link
Contributor

@BHoMBot check unit tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2021

@LMarkowski sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to run?
For a list of available instructions, please see this wiki page.

@LMarkowski
Copy link
Contributor

@BHoMBot check unit tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2021

@LMarkowski sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to run?
For a list of available instructions, please see this wiki page.

@LMarkowski
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2021

@LMarkowski to confirm, check-unit-tests task is now queued.

@pawelbaran
Copy link
Member Author

Following the discussion with @LMarkowski, the test script as well as UT has been updated to prove the correctness of the code developed in this PR. In parallel #2380 has been raised to highlight the issue we have found in the previous version of UT.

@pawelbaran pawelbaran mentioned this pull request Mar 9, 2021
Merged
@LMarkowski
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2021

@LMarkowski to confirm, check-unit-tests task is now queued.

LMarkowski
LMarkowski previously approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@LMarkowski LMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing unit test is not relevant for this PR. Code and test script look good and work as they should.

@pawelbaran pawelbaran changed the title Rigid transformations for IElements0D, IElements1D and IElements2D added Spatial_Engine: Rigid transformations for IElements0D, IElements1D and IElements2D added Mar 9, 2021
@pawelbaran
Copy link
Member Author

/azp run BHoM_Engine.CheckInstaller

@pawelbaran
Copy link
Member Author

@BHoMBot check all

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, if applicable check-copyright-compliance, check-serialisation, check-versioning, check-unit-tests, check-core, check-installer, and check-ready-to-merge tasks are now queued.

@pawelbaran
Copy link
Member Author

@LMarkowski I have added transforms for RenderMesh and Vertex to support BHoM/Revit_Toolkit#982. Everything else stays the same as before.

@LMarkowski LMarkowski self-requested a review March 10, 2021 13:12
@pawelbaran pawelbaran mentioned this pull request Mar 10, 2021
Closed
LMarkowski
LMarkowski approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@LMarkowski LMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelbaran
Copy link
Member Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pawelbaran
Copy link
Member Author

@BHoMBot check all

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, if applicable check-copyright-compliance, check-serialisation, check-versioning, check-unit-tests, check-core, check-installer, and check-ready-to-merge tasks are now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-unit-tests task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-serialisation task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-installer task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, check-core task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2021

@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@FraserGreenroyd FraserGreenroyd merged commit ebc4329 into master Mar 10, 2021
@FraserGreenroyd FraserGreenroyd deleted the Spatial_Engine-#2320-RigidTransformations branch March 10, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMarkowski LMarkowski LMarkowski approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@pawelbaran pawelbaran

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement rigid body transform for spatial objects
3 participants
@pawelbaran @LMarkowski @FraserGreenroyd